-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Production Workflows for Docker and Docs #901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty cool, good solution :D
@SteveDMurphy I don't feel a need to publish old docs versions, I think it'll be good enough to have going forward but not worth back-filling |
* Step output conditional for workflow, tag to image * Have doc publish with version number * remove TAG env var from workflows * changelog
Closes #807
Code Changes
github.event.ref
to publish the version specific docsSteps to Confirm
IMAGE
constant with versionPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Spent some time in a test repo to ensure the workflow updates should work for us.
I'm unsure still if the nox changes are sufficient, or if there should be a separate constant used for the current working version.
Another additional question is if we want to retroactively publish docs versions that were missed 🤔